hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lisakowen <...@git.apache.org>
Subject [GitHub] incubator-hawq-docs pull request #94: HAWQ-1304 - multiple doc changes for P...
Date Wed, 08 Feb 2017 16:59:43 GMT
Github user lisakowen commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq-docs/pull/94#discussion_r100115473
  
    --- Diff: markdown/pxf/ReadWritePXF.html.md.erb ---
    @@ -131,6 +149,8 @@ Note: The <code class="ph codeph">DELIMITER</code> parameter
is mandatory.
     </tbody>
     </table>
     
    +**Notes**: Metadata identifies the Java class that provides field definitions in the
relation. OutputFormat identifies the file format for which a specific profile is optimized.
While the built-in `Hive*` profiles provide Metadata and OutputFormat classes, most profiles
will have no need to implement or specify these classes.
    --- End diff --
    
    the statement is kind of vague, yes.  i will make it clearer.  
    
    it seems to me that the outputFormat property is more admin- or developer-focused.  what
i mean here is that a typical end-user using a Hive* profile probably does not need to know
about the setting.  an admin configuring custom profiles or a developer creating a custom
plug-in may be interested.  the current admin- and developer- focused PXF docs need some attention.
 can we address a more detailed discussion of this property as part of that rework at a later
time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message