hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dyozie <...@git.apache.org>
Subject [GitHub] incubator-hawq-docs pull request #94: HAWQ-1304 - multiple doc changes for P...
Date Fri, 03 Feb 2017 17:51:16 GMT
Github user dyozie commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq-docs/pull/94#discussion_r99386323
  
    --- Diff: markdown/pxf/PXFExternalTableandAPIReference.html.md.erb ---
    @@ -885,7 +923,7 @@ public class Constant
     
     #### <a id="filterobject"></a>Filter Object
     
    -Filter Objects can be internal, such as those you define; or external, those that the
remote system uses. For example, for HBase, you define the HBase `Filter` class (`org.apache.hadoop.hbase.filter.Filter`),
while for Hive, you use an internal default representation created by the PXF framework,
called `BasicFilter`. You can decide the filter object to use, including writing a new one.
`BasicFilter` is the most common:
    +Filter Objects can be internal, such as those you define; or external, those that the
remote system uses. For example, for HBase, you define the HBase `Filter` class (`org.apache.hadoop.hbase.filter.Filter`),
while for Hive, you use an internal default representation created by the PXF framework,
called `BasicFilter`. You can choose the filter object to use, including writing a new one.
`BasicFilter` is the most common:
    --- End diff --
    
    Change the ; to a , (or use dashes as instead like -such as those you define-)
    
    Also remove the commas after HBase, and Hive, in the second sentence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message