Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6A448200C02 for ; Fri, 20 Jan 2017 22:53:21 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 68DAC160B48; Fri, 20 Jan 2017 21:53:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8D9A4160B34 for ; Fri, 20 Jan 2017 22:53:20 +0100 (CET) Received: (qmail 62356 invoked by uid 500); 20 Jan 2017 21:53:19 -0000 Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list dev@hawq.incubator.apache.org Received: (qmail 62344 invoked by uid 99); 20 Jan 2017 21:53:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jan 2017 21:53:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F050BC0054 for ; Fri, 20 Jan 2017 21:53:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.48 X-Spam-Level: ** X-Spam-Status: No, score=2.48 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=pivotal-io.20150623.gappssmtp.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id qM28_wk-u2aV for ; Fri, 20 Jan 2017 21:53:17 +0000 (UTC) Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0E54C5F27D for ; Fri, 20 Jan 2017 21:53:16 +0000 (UTC) Received: by mail-wm0-f50.google.com with SMTP id c206so64825908wme.0 for ; Fri, 20 Jan 2017 13:53:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=pVUySKVYuIPcQrWfj7nCmV9Pzqt6D0gEDK6QIKzlMCE=; b=ToUskhueLAY5ClKvBH22RO1q/S1D0hoLPc0fIzfbfftj1P0R/xoV0IYhI/RsXKKKQZ aMF3vY8fMybYPqR39k412s4Z5TasLrWfZFiUvD62hTahGwK0d83AmXwyENHb2FwREWZo 5+qWXSxdhA5PL5qdawxl4oQ4FovPPW+MjQEynMtQvb7AUhSQynokAo6bCYoL9KSn/6xq /BNa19I+B++4xHPHT0JtNt1Eme+eGL5D/D86mIdJft8dRbMqtwkcYcO/9zIZEblkUABb Hje50SVJei55lXT18fs5yyfgVKv1N0UAgFoE2EL5ekoT5TD/uk+hSnONsIND7Cx+pLRg B58A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=pVUySKVYuIPcQrWfj7nCmV9Pzqt6D0gEDK6QIKzlMCE=; b=O4ug2KHVjt22cRDimPjE142FcPjnb7fq1odKv4ftMAXlqNiNHpFIRrJ9Onmm0eBSwP kQlS1Gi4jJB6AJYGCXuyhoZ3m74OhJL5TzRPN4FrVLeYXcvxOr2igtjYJNU/biBE7YjR h3xGvA+U44sUW0Q7kxu20QkP5tD/GwKPaTeOmIaRBxof1Svz+QnYv10zgRVOsp2n2/iR Rx6mIYEqSg8g4MUtWIXorNXD7Hr/FipvaEQpbzmiPvvvgIw6OPrRlqdwY2dQmcJdmsS3 VTi8XtNQ/iUcc9s3zouuXpXl/TC3ujrQCIVGWnzTJorRVT0tpphF3NQhNkC/ICVMvuUt fM2A== X-Gm-Message-State: AIkVDXIBUHLTk9nMShCWFwiN+CVqqSJG5lxIHt2sWklJ+V20V7gFlbmaTZQ3IqykMsr19/nhbNRg39NFag76joFP X-Received: by 10.223.176.93 with SMTP id g29mr13874786wra.7.1484949193604; Fri, 20 Jan 2017 13:53:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.144.141 with HTTP; Fri, 20 Jan 2017 13:53:13 -0800 (PST) In-Reply-To: References: From: Lisa Owen Date: Fri, 20 Jan 2017 13:53:13 -0800 Message-ID: Subject: Re: HAWQ server configuration parameters (GUCs) To: dev@hawq.incubator.apache.org Content-Type: multipart/alternative; boundary=001a113bef5631dcc405468dadd7 archived-at: Fri, 20 Jan 2017 21:53:21 -0000 --001a113bef5631dcc405468dadd7 Content-Type: text/plain; charset=UTF-8 thanks for the info, ruilong. just realized that an attachment to the original email was not included. i've created a JIRA for outcomes of this discussion and included the spreadsheet there: https://issues.apache.org/jira/browse/HAWQ-1290. -lisa On Fri, Jan 20, 2017 at 6:59 AM, Ruilong Huo wrote: > Here is some general description of server configuration. Though some of > hawq guc is not following that. > > DEFUNCT GUC: should not be in doc; should not show in hawq config > > DEPRECATED GUC: should be in doc and mention that they are deprecated; > should show in hawq config > > DEVELOPER GUC: should not in doc; should not show in hawq config. More > details can be found in > https://www.postgresql.org/docs/9.5/static/runtime-config-developer.html > > PRESET GUC: should be in doc as read only; should show in hawq config. More > details can be found in > https://www.postgresql.org/docs/9.5/static/runtime-config-preset.html > > > Best regards, > Ruilong Huo > > On Fri, Jan 20, 2017 at 1:28 AM, Lisa Owen wrote: > > > hi hawq developers, > > > > i have been looking at src/backend/utils/misc/guc.c to try to get a > better > > understanding of hawq server configuration parameters (GUCs) and how they > > are exposed to end users and developers. i have initially focused on > GUCs > > with config groups labeled "DEVELOPER_OPTIONS", "DEFUNCT_OPTIONS", > > "DEPRECATED_OPTIONS", and "PRESET_OPTIONS". > > > > i have some general questions regarding these GUC config groups: > > 1. which GUCs and their values should be displayed/changeable via > "hawq > > config" command? > > 2. which of the GUCs are updatable, which are read-only? > > 3. which of the GUCs should be documented to the end user, and if/how > > to "flag them"? > > > > DEVELOPER_OPTIONS - it appears we expose some developer GUCs to the > > end-user. what does it mean for a GUC to be a developer option? (when) > > should developer options be displayed in "hawq config -l" output? (when) > > should developer GUCs be discussed in the docs? it seems we are somewhat > > inconsistent in these areas. many, but not all, of the GUCS labeled as > > "DEVELOPER_OPTIONS" are also identified as "GUC_NO_SHOW_ALL", which > > generally excludes them from "hawq_config -l" output. the documentation > > currently describes a few of the developer GUCs. if we are describing > > developer GUCs in end-user documentation, should we be flagging them as > > such? > > > > DEFUNCT_OPTIONS - the GUCs labeled "DEFUNCT_OPTIONS" are pretty > > straightforward from an external perspective - none of them are currently > > documented, and none show up in "hawq config -l" output. > > > > DEPRECATED_OPTIONS - GUCs that are part of the "DEPRECATED_OPTIONS" > config > > group are functioning, but not recommended for use. some are documented, > > some are not. should we be explicitly identifying deprecated GUCs as > such > > in the documentation? should we even be documenting them at all? should > > the values of deprecated GUCs show up in "hawq config -l" output? > > > > PRESET_OPTIONS - some of the GUCS labeled with "PRESET_OPTIONS" are > > identified as read-only in the documentation. i used hawq config to > change > > one of them, "hawq config -c block_size -v 32768", and the operation > > apparently worked (i.e. no error returned). so, what does it mean for a > > GUC to be preset? read-only? are they all read-only? some appear to be > > recognized by "hawq config -c" command, while others are not. > > > > i've pulled together a spreadsheet identifying the "DEVELOPER_OPTIONS", > > "DEFUNCT_OPTIONS", "DEPRECATED_OPTIONS", and "PRESET_OPTIONS" GUCs and > > whether or not: > > - the GUC is documented in the current HAWQ docs > > - the GUC and associated value show up in "hawq config -l" output > > (when run by superuser) > > and other notes. > > > > thanks for any clarity you can provide on which of these GUCs we should > be > > exposing to the end user. > > > > > > -lisa > > > > > > > --001a113bef5631dcc405468dadd7--