hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lisakowen <...@git.apache.org>
Subject [GitHub] incubator-hawq-docs pull request #46: HAWQ-1119 - create doc content for PXF...
Date Wed, 18 Jan 2017 18:47:06 GMT
Github user lisakowen commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq-docs/pull/46#discussion_r96705982
  
    --- Diff: markdown/pxf/HDFSWritablePXF.html.md.erb ---
    @@ -396,7 +394,7 @@ The field type of `recordkey` must correspond to the key type, much
as the other
     
     ### <a id="example1"></a>Example: Using Record Keys
     
    -Create an external readable table to access the record keys from the writable table `pxf_tbl_seqwrit`
that you created in [Example: Writing Data Using the SequenceWritable Profile](#profile_hdfsseqwritable_writing).
 The `recordkey` is of type `int8`. (We did not identify a record key when creating the writable
table.
    +Create an external readable table to access the record keys from the writable table `pxf_tbl_seqwrit`
that you created in [Example: Writing Data Using the SequenceWritable Profile](#profile_hdfsseqwritable_writing).
 The `recordkey` is of type `int8`. (You did not identify a record key when you created the
writable table.
    --- End diff --
    
    those two sentences are not directly related.  the type of recordkey will always be int8.
 i am going to just remove the "You did not identify a record key..." sentence as a variant
is used after the example.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message