Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
Date: Mon, 5 Sep 2016 15:14:52 +0000 (UTC)
From: Lei Chang <chang.lei.cn@gmail.com>
To: dev@hawq.incubator.apache.org,  <dev@hawq.incubator.apache.org>
Message-ID: <F734237186262828.F9AB6C53-F63D-4513-8E7C-20EFC228106D@mail.outlook.com>
In-Reply-To: <CABQrizff9iwsTMATrx5B9Jpq=Fp_7BJfem0R-w5jvCbrEv0gEQ@mail.gmail.com>
References: <CABQrizff9iwsTMATrx5B9Jpq=Fp_7BJfem0R-w5jvCbrEv0gEQ@mail.gmail.com>
Subject: Re: enforce -Werror (if gcc) in hawq?
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_4724_1302701291.1473088492871"
archived-at: Mon, 05 Sep 2016 15:15:00 -0000

------=_Part_4724_1302701291.1473088492871
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

In the past, it is enabled by default. Looks like it is a regression during oss and build refactoring process.

Cheers
Lei


On Mon, Sep 5, 2016 at 6:05 PM +0800, "Paul Guo" <paulguo@gmail.com> wrote:


-Werror
Make all warnings into errors.
I've seen many cases (not just hawq) before that ignoring gcc warning leads
to bugs. I'm wondering we should add the option for the gcc case. Given
there may be a lot of warnings when building the common postgres code in
hawq, we could at least enforce it in our own code at first
(src/backend/cdb, src/backend/resourcemanager, src/test/feature, other
directories?)? Any suggestion?


------=_Part_4724_1302701291.1473088492871--