Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
MIME-Version: 1.0
Sender: shaposhnik@gmail.com
In-Reply-To: <CA+F1ufmG+M2DL5eFPNqK6CE3SPw76YnQMf5w+0BAB+Q51KRGhw@mail.gmail.com>
References: <CA+F1ufkPN=Yfmx05jTXOeGjM5WdsnYP+eE271-zjxevGQvht7Q@mail.gmail.com>
 <CAE44UQd=+qOh4Ebi1YBoO4T9AK-2yxW=6G8xLdms7DqybAphjg@mail.gmail.com>
 <CA+ULb+sFN7Usnf5Mh_4Dxf3NUeuyyZwd47jmb_B6n+g4psQL0A@mail.gmail.com>
 <CA+F1ufke72DGTKqSgs8vL=LZeMaVUHizwXhjZ_HLPxVBHMvuFg@mail.gmail.com>
 <CA+F1ufmStR4hL6NZ=5ytGTAQs0YoDPMC7QWw5RWocPeddudHTQ@mail.gmail.com>
 <F734237186262828.D52F0D65-7904-49FE-A422-7BE2328327C8@mail.outlook.com> <CA+F1ufmG+M2DL5eFPNqK6CE3SPw76YnQMf5w+0BAB+Q51KRGhw@mail.gmail.com>
From: Roman Shaposhnik <roman@shaposhnik.org>
Date: Fri, 9 Sep 2016 12:27:36 -0700
Message-ID: <CA+ULb+uRMRN7-OEvhAf7=8H6SSkFGEEy+OWZjL8SzhqVrsM67w@mail.gmail.com>
Subject: Re: Please append 'close #PR_id' to commit message when you merge
 other's pull request
To: dev@hawq.incubator.apache.org
Content-Type: text/plain; charset=UTF-8
archived-at: Fri, 09 Sep 2016 19:27:49 -0000

E.g.

$ git commit -m 'HAWQ-XXX. This is a commit log line

closes #YYY'

Note that once you type ' on the command line you can type
a new line character and keep typing until you hit ' again.

Thanks,
Roman.

On Fri, Sep 9, 2016 at 1:19 AM, Ming Li <mli@pivotal.io> wrote:
> Yes, I wonder how to add to the body. It seems there is only message
> without title/body.
> Could you share me the shell command?
>
> Thanks Lei.
>
> On Fri, Sep 9, 2016 at 4:13 PM, Lei Chang <chang.lei.cn@gmail.com> wrote:
>
>> ming, I think Roman has already suggested a solution. Add "close #" in the
>> commit message body instead of message title. Does it solve your concerns?
>>
>> Cheers
>> Lei
>>
>>
>>
>>
>> On Fri, Sep 9, 2016 at 1:09 PM +0800, "Ming Li" <mli@pivotal.io> wrote:
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> I think we should offer a solution for this problem, even if the solution
>> is not good enough. If you find a better solution for it, we can  enhance
>> it afterward.
>>
>> On Thu, Sep 8, 2016 at 3:16 PM, Ming Li  wrote:
>>
>> > Hi Roman,
>> >
>> > The problem is still have someone forget to close PR, and we can't
>> contact
>> > him only using email notification.
>> >
>> > As for your suggestion, could you please share with us the exact steps
>> how
>> > to do it? Thanks.
>> >
>> > On Thu, Sep 8, 2016 at 2:13 PM, Roman Shaposhnik
>> > wrote:
>> >
>> >> On Wed, Sep 7, 2016 at 11:08 PM, Lei Chang  wrote:
>> >> > @ming, there is a discussion on this mailing list before about what
>> >> should
>> >> > be included in the commit message.
>> >> >
>> >> > Appending "close #" makes the commit message very messy.
>> >> >
>> >> > So the conclusion at that time is to not append "close #" to a commit
>> >> > message.
>> >> >
>> >> > If someone forgets closing a pull request, looks better to add a
>> >> reminder
>> >> > to the pull request.
>> >>
>> >> Not to reopen that old discussion, but have you guys considered adding
>> >> it to the body of the commit? That way it won't mess up git log and such
>> >> but will still have the desired effect.
>> >>
>> >> Thanks,
>> >> Roman.
>> >>
>> >
>> >
>>
>>
>>
>>
>>
>>