Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=gb2312
From: Gmail <xunzhangthu@gmail.com>
Mime-Version: 1.0 (1.0)
Date: Wed, 6 Jul 2016 19:35:30 +0800
Message-Id: <ECAA6F7E-5B6B-432B-A1F2-D60ED3C94975@gmail.com>
Subject: Re: Replace git submodule with git clone + file with commit number?
References: <CABQrizdJJMQY6vFLJ0_qcRHw-BH3QcQmTOSv0KoC-9Y8PfHiOA@mail.gmail.com>
In-Reply-To: <CABQrizdJJMQY6vFLJ0_qcRHw-BH3QcQmTOSv0KoC-9Y8PfHiOA@mail.gmail.com>
To: dev@hawq.incubator.apache.org
archived-at: Wed, 06 Jul 2016 11:35:40 -0000

I think the method using git clone is fine.=20

But I suggest we'd better keep the makefile readable. I mean we should not a=
dd too trivial shell logic inside makefile itself. For example, write a shel=
l or Python script for users. Users should run the script before building HA=
WQ if they need to install this libraries.

I also wonder what's the typical solution for similar problems of other Apac=
he projects. Do they use git sub module? How do they solve this in their rel=
ease?

xunzhang

Send from my iPhone

> =D4=DA 2016=C4=EA6=D4=C229=C8=D5=A3=AC18:18=A3=ACGuo Gang <paulguo@gmail.c=
om> =D0=B4=B5=C0=A3=BA
>=20
> I'm proposing this change because:
>=20
> 1) We are ready to release the first apache release with "source tarball",=

> but
>   submodule is not friendly to source tarball since git submodule
>  require a git parent.
>=20
> 2) With more and more development, I found that submodule mechanism
>   is not that friendly for development, e.g.
>=20
>   If the commit number of one submodule is modified, it is hard to detect
>   this for Makefile. We need to manually update it in an old repo. If
>   using "git clone", we could easily detect update by set a commit number
> file
>   as dependency and thus easily update the code.
>=20
>  Some developers have complained the annoying output in "git status"
>  after building submodules. With "git clone" we can easily mask those
>  directories via .gitignore.
>=20
>  It is hard for developers who is not familiar with submodule (Frankly
> speaking
>  I really do not think submodule is friendly) to manipulate related
> directories
>  when necessary.
>=20
> While with the "git clone" solution, we save the commit of previous
> submodule in a file,
> and the related Makefile code change is rather simple, e.g. for gp-xerces.=

>=20
> $(ORCA_BLD_PATH)/gp-xerces_prepare_timestamp:
> $(ORCA_SRC_PATH)/gp-xerces.commit
>   rm -f $(ORCA_BLD_PATH)/gp-xerces_prepare_timestamp
>=20
> gp-xerces_prepare: $(ORCA_BLD_PATH)/gp-xerces_prepare_timestamp
>   if [ ! -f $(ORCA_BLD_PATH)/gp-xerces_prepare_timestamp ]; then \
>       [ "x$(gp_xerces_commit)" !=3D "x" ] || exit 1; \
>       cd $(abs_top_srcdir)/$(subdir); mkdir -p gp-xerces; cd gp-xerces; \
>       [ ! -d .git ] && git clone
> https://github.com/greenplum-db/gp-xerces.git .; \
>       git reset --hard $(gp_xerces_commit) || exit 2; \
>       touch $(ORCA_BLD_PATH)/gp_xerces_prepare_timestamp; \
>   fi
>=20
> With above code change, if I update gp-xerces commit number in the commit
> file
> gp-xerces.commit make will trigger an auto-build, If I messed up the
> gp-xerces directory
> I can easily remove the whole gp-xerces, or just remove the timestamp file=

> gp-xerces_prepare_timestamp to trigger an auto build.
>=20
> Any suggestion? Thanks.