Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9170B200B49 for ; Wed, 20 Jul 2016 04:35:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8FD5B160A8B; Wed, 20 Jul 2016 02:35:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D6D8B160A76 for ; Wed, 20 Jul 2016 04:35:02 +0200 (CEST) Received: (qmail 73412 invoked by uid 500); 20 Jul 2016 02:35:02 -0000 Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list dev@hawq.incubator.apache.org Received: (qmail 73400 invoked by uid 99); 20 Jul 2016 02:35:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jul 2016 02:35:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4595E185DBB for ; Wed, 20 Jul 2016 02:35:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.179 X-Spam-Level: * X-Spam-Status: No, score=1.179 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id PQwa9kuyNA6T for ; Wed, 20 Jul 2016 02:34:59 +0000 (UTC) Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 88F5D5F1F3 for ; Wed, 20 Jul 2016 02:34:58 +0000 (UTC) Received: by mail-wm0-f45.google.com with SMTP id q128so38132832wma.1 for ; Tue, 19 Jul 2016 19:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=NKHvLZgd75Zcb3Qf5W7UD4cMEpSMwezAcYBtWYAEFX8=; b=kKlpgP+kjsvguR8jbHyfKFhvHPQsBuPGpRoxIXfw8stxo/MvDd+Czli6YZrgZDmLPq QIf2zV+qyigY+RA3/A+ppx5AX8lDav7pXoYYSUCMsTfhvT56FFNv5p7ARSMDAi1ZDlrZ bvFngECxyyu0SeRtmpWCuz6aVoVIS9hWjuodhv4ClodPsxVEMUaMBFrqmYA+P+LlAbQX onUe9QPlwxFJJS+Z49Qm1IMzER7608CyZdLOAUmjTtZKpG08/K9syMtYHArfjv72Om/Q Cx4cC4uJ2SPnB3BXcl37BGec6tZCzg5y3ag76sOHhMYS7BUYDj0s/SzYGwVapzbibYAD V2cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=NKHvLZgd75Zcb3Qf5W7UD4cMEpSMwezAcYBtWYAEFX8=; b=O39z9M3AAjHsRud15+/qm/Rd98Po53G56YohMOTk7QPq+dvbZLR5S2X4+SeWoWwp33 qwzsoU0/i7kwma+GMlqlsLaqCX+aL0xkM1dBnYMk0Hz1x8rsKf+ioFTpPzdUpOMtBuTw lPQYzoaJLEtBz0KSzEp8CSXmtIr9zvVp52JJP/WTRBM3PGdZxHmILa8cZMjunqVG51oZ tSHGafKNDkJJ6SkthDvGI5N0aVnp+yE2IN5G52fM3LlrPQy3WoaInHe5koFPqU8l0u+M 4XCVKAGuqOWfcqcilwj7Agl5F1ynrqflhDsj/ZwjB8IDqekBmO4I9ZO87Z9UesP4TaWD cmNg== X-Gm-Message-State: ALyK8tJD8HNg8XfDPiusjR0vLFHk/j/0+v5q3975swcolZm8iQJUMgKQw4NSDwgWUU5cTwPVHznj1Zro6BleTA== X-Received: by 10.28.111.213 with SMTP id c82mr8167834wmi.47.1468982092165; Tue, 19 Jul 2016 19:34:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.136.65 with HTTP; Tue, 19 Jul 2016 19:34:51 -0700 (PDT) In-Reply-To: References: From: Paul Guo Date: Wed, 20 Jul 2016 10:34:51 +0800 Message-ID: Subject: Re: Jira comments vs PR comments To: dev@hawq.incubator.apache.org Content-Type: multipart/alternative; boundary=001a1146a166c8f6950538080b0d archived-at: Wed, 20 Jul 2016 02:35:03 -0000 --001a1146a166c8f6950538080b0d Content-Type: text/plain; charset=UTF-8 +1. Github has already have fine-grained notification mechanism. I think JIRA could just pull the initial git pull request info, not each comment in github. I guess this is either a JIRA configuration issue or an asf/infrustructure issue. 2016-07-20 2:57 GMT+08:00 Goden Yao : > 2nd that. JIRA right now can already link to the PR under "issue links to" > section. (e.g.: https://issues.apache.org/jira/browse/HAWQ-936 ) > Not sure if that was automatic or manual but I prefer that way instead of > auto-pulling every PR comment into the JIRA (even closing PR is a comment). > > JIRA discussion should be focused on the problem to solve and design, etc. > While PR comments are mainly for coding details, logic errors, naming > issues, formats, coding style etc. > > -Goden > > On Tue, Jul 19, 2016 at 11:52 AM Shivram Mani > wrote: > > > Its great that Jira and github has been linked, but this integration is > > also making it hard for us to skim through actual comments posted in > Jira. > > Jiras usually end up being innundated with every single comment posted in > > the pull request. > > This makes it hard for us to actually read through/search for actual > > comments/discussions posted on the Jira amidst the pull requestion > > notifications for each comment. > > > > Can we disable pull request comment based notifications from being posted > > on the Jira ? > > Thoughts ? > > > > -- > > shivram mani > > > --001a1146a166c8f6950538080b0d--