Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <CALkokyWaVAKFbpAH2rteUjghOD7MeBvGF8hktb-4HX2L_AgwPg@mail.gmail.com>
References: <CABQrizdcMybfRMaqQomE+P+Zx8N_mXebYJebQddSAtQVzHSixA@mail.gmail.com>
 <CALkokyWaVAKFbpAH2rteUjghOD7MeBvGF8hktb-4HX2L_AgwPg@mail.gmail.com>
From: Paul Guo <paulguo@gmail.com>
Date: Tue, 12 Jul 2016 13:18:53 +0800
Message-ID: <CABQrizcpbmUnqSx4G04+JjFW6TqVafDcAEAYPUz7mN0GbAy5eg@mail.gmail.com>
Subject: Re: About *.out files in test/feature
To: dev@hawq.incubator.apache.org
Content-Type: multipart/alternative; boundary=089e0122ed1ca75816053769672f
archived-at: Tue, 12 Jul 2016 05:19:00 -0000

--089e0122ed1ca75816053769672f
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I would leave .diff file at least unmasked so that people could quickly
find what cases failed.

2016-07-12 11:38 GMT+08:00 =E9=99=B6=E5=BE=81=E9=9C=96 <ztao1987@apache.org=
>:

> Besides .out, there also exists .diff, binary which should be ignored.
>
> 2016-07-12 11:32 GMT+08:00 Paul Guo <paulguo@gmail.com>:
>
> > I'd mask the output files after running feature tests in .gitignore and
> > clean it up after running "make clean" or "make distclean". Anyone has
> any
> > suggestions? Thanks.
> >
> > diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
> > index a2e6bd4..c7332b2 100644
> > --- a/src/test/feature/.gitignore
> > +++ b/src/test/feature/.gitignore
> > @@ -1 +1,2 @@
> >  doc/
> > +**/*.out
> >
> > diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> > index adc6acc..e0985d1 100644
> > --- a/src/test/feature/Makefile
> > +++ b/src/test/feature/Makefile
> > @@ -35,6 +35,7 @@ doc:
> >     doxygen doxygen_template
> >
> >  clean distclean: sharelibclean
> > +   find . -type f -name "*.out" |xargs rm -f
> >     $(RM) feature-test
> >     $(RM) feature-test.dSYM
> >
>

--089e0122ed1ca75816053769672f--