hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Radar Da lei <r...@pivotal.io>
Subject Re: [VOTE] HAWQ 2.0.0-incubating Release
Date Thu, 14 Jul 2016 14:04:00 GMT
Seems now all the blockers are fixed. Waiting merge into the branch.

I will merge HAWQ-926 <https://issues.apache.org/jira/browse/HAWQ-926> into
the release branch after RAT changes are in to avoid conflict.

Thanks.

Regards,
Radar

On Thu, Jul 14, 2016 at 1:27 AM, Ting(Goden) Yao <tyao@pivotal.io> wrote:

> Per the discussion: we now still have 2 issues:
>
>    - https://issues.apache.org/jira/browse/HAWQ-915 (RAT check issues),
>    this is being worked on
>    - make pycrypto dependency optional : there's contradictory JIRAs
>    https://issues.apache.org/jira/browse/HAWQ-863 (add pycrypto module
>    back) - fixed
>    https://issues.apache.org/jira/browse/HAWQ-271 (remove python modules)
> -
>    fixed
>    Please whoever knows the details, file a new JIRA , so we start with a
>    clean slate for this release.
>
>
> Thanks
> -Goden
>
> On Tue, Jul 12, 2016 at 4:22 PM Ting(Goden) Yao <tyao@pivotal.io> wrote:
>
> > HAWQ-919 has been resolved and ported to 2.0.0.0-incubating branch.
> >
> > On Tue, Jul 12, 2016 at 3:45 AM Paul Guo <paulguo@gmail.com> wrote:
> >
> >> I've sent a pull request to resolve the rat issue,
> >>
> >>            https://github.com/apache/incubator-hawq/pull/788
> >>
> >> There are still several pxf related files which have license issues.
> >>
> >> We filed another JIRA to let the pxf guys fix this.
> >>
> >> <https://issues.apache.org/jira/browse/HAWQ-919>
> >>
> >>       https://issues.apache.org/jira/browse/HAWQ-919
> >>
> >>
> >> 2016-07-12 11:00 GMT+08:00 Paul Guo <paulguo@gmail.com>:
> >>
> >> > 0. Yes, RAT check failures need to be handled. I do not know much
> about
> >> RAT
> >> >     but if we could just check affect files of one patch I'd 100%
> agree
> >> it
> >> > is in CI.
> >> >
> >> > 1. Those "git-cloned" repo are "git-cloned" only when necessary (i.e.
> >> when
> >> >     related options are specified in configure command.
> >> >
> >> > 2. The thrift info has been in the ImportLogs file. I'd suggest move
> >> this
> >> > (probably
> >> >      with more details) into the README file.
> >> >
> >> > 2016-07-12 0:33 GMT+08:00 Roman Shaposhnik <roman@shaposhnik.org>:
> >> >
> >> >> On Mon, Jul 11, 2016 at 2:27 AM, Radar Da lei <rlei@pivotal.io>
> wrote:
> >> >> > Hi Goden,
> >> >> >
> >> >> > I have pushed commits of 'HAWQ-892
> >> >> > <https://issues.apache.org/jira/browse/HAWQ-892>' and 'HAWQ-901
> >> >> > <https://issues.apache.org/jira/browse/HAWQ-901>' into branch
> >> >> > '2.0.0.0-incubating'.
> >> >>
> >> >> Ok, with these two additional commits I presumed the branch was ready
> >> >> for review. I'm not done with the full review yet, but here are the
> top
> >> >> concerns
> >> >> that would make me -1 this branch if it did go for a vote:
> >> >>    0. mvn verify produces tons of RAT check failures that need to be
> >> >> carefully
> >> >>    analyzed. As an aside -- I highly recommend having a CI job that
> >> >> runs mvn verify
> >> >>    on a regular basis.
> >> >>
> >> >>    1. Pulling source from external repositories in an unconditional
> >> way.
> >> >>     There's quite a bit of 'git clone' going on in the build system.
> >> >> The easiest way
> >> >>     to see it all is to run
> >> >>        $ git grep -R 'git ' . | grep clone
> >> >>     My first concern is that all of these calls need to be made
> >> >> conditional. IOW,
> >> >>     I should be able to build a basic HAWQ binary without it doing
> >> >> 'git clone' and
> >> >>     instead relying on pointers to the same binary dependencies
> >> provided
> >> >> via
> >> >>     build configuration. This could be a documentation issue and if
> so
> >> >> I'd appreciate
> >> >>     having it published on the wiki some place.
> >> >>
> >> >>     On top of that, we have two bigger issues with the following
> repos:
> >> >>         https://github.com/jconway/plr.git  -- GPL
> >> >>         https://github.com/postgres/postgres.git -- Cryptography
> >> >>
> >> >>     We need to make sure that HAWQ can be built with those
> altogether.'
> >> >>
> >> >>     2. As a minor nit, I see that you imported thrift source under
> >> >> depends/thirdparty/thrift
> >> >>     and it would be great if there were a way to:
> >> >>         2.1. make sure that it is obvious what *release* version of
> >> >> thrift it was
> >> >>         2.2. make sure that it is obvious if anything in there gets
> >> >> patched
> >> >>
> >> >>
> >> >> Thanks,
> >> >> Roman.
> >> >>
> >> >
> >> >
> >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message