hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Weng <iw...@pivotal.io>
Subject Re: sanity-check before running cases in feature-test
Date Tue, 12 Jul 2016 06:15:57 GMT
Agree with Hong. Test case should check its environment needed. If the
check failed, it should terminate the execution and report the error.

On Tue, Jul 12, 2016 at 2:04 PM, Hong Wu <xunzhangthu@gmail.com> wrote:

> It is user/developer themselves that should take care. Say, if you write a
> test case which is related to plpython, why don't you configure HAWQ with
> "--with-python" option? We should write a README for feature-test that
> guides user to run this tests. For example, tell them sourcing
> "greenplum.sh" before running tests.
>
> Consequently, I think add such sanity-check is a little bit of
> over-engineering which will bring extra problems and complexities.
>
> Best
> xunzhang
>
> 2016-07-12 13:47 GMT+08:00 Paul Guo <paulguo@gmail.com>:
>
> > I have >1 times to encounter some feature test failures due to reported
> > missing stuffs.
> >
> > e.g.
> >
> > 1. I did not have pl/python installed in my hawq build so
> >    UDF/sql/function_set_returning.sql fails to "create language
> plpythonu"
> >    This makes this case fails.
> >
> > 2. Sometimes I forgot to source a greenplum.sh, then all cases run
> >     with failures due to missing psql.
> >
> > We seem to be able to improve.
> >
> > 1) Sanity-check some file existence in common code, e.g.
> >     psql, gpdiff.pl,
> >
> > 2) Some cases could do sanity-check in their own test constructor
> > functions,
> >     e.g. if the case uses the extension plpython, the test case should
> > check it itself.
> >
> > More thoughts?
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message