hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Guo <paul...@gmail.com>
Subject Re: About *.out files in test/feature
Date Tue, 12 Jul 2016 05:35:56 GMT
Although gnu distclean means below, but the explananation is incomplete.
Things

could be more complex than simple configuration & build. Besides,

We are not GNU programs so we do not have to 100% follow the GNU convention.

The key point is that we need a target to make repo clean.


<https://www.gnu.org/prep/standards/html_node/Standard-Targets.html>
https://www.gnu.org/prep/standards/html_node/Standard-Targets.html
‘distclean’
<https://www.gnu.org/prep/standards/html_node/Standard-Targets.html>
<https://www.gnu.org/prep/standards/html_node/Standard-Targets.html>

Delete all files in the current directory (or created by this makefile)
that are created by configuring or building the program. If you have
unpacked the source and built the program without creating any other files,
‘make distclean’ should leave only the files that were in the distribution.
However, there is no need to delete parent directories that were created
with ‘mkdir -p’, since they could have existed anyway.




2016-07-12 11:57 GMT+08:00 Gmail <xunzhangthu@gmail.com>:

> I agree with ruilong.
> Make clean should clean files generated only in make process.
>
> Make distclean should clean files generated in make and configure process.
>
> xunzhang
> Send from my iPhone
>
>
>
> 发自我的 iPhone
> > 在 2016年7月12日,11:40,Ruilong Huo <rhuo@pivotal.io> 写道:
> >
> > I think "make clean" should only clean the files generated during compile
> > process.
> > The *.out files are created by feature test code with psql, so I would
> > prefer keep them.
> > If you would like to clean them, that should be in feature test
> framework,
> > not in makefile.
> >
> > Any comments?
> >
> > Best regards,
> > Ruilong Huo
> >
> >> On Tue, Jul 12, 2016 at 11:37 AM, Xiang Sheng <xsheng@pivotal.io>
> wrote:
> >>
> >> We indeed should delete these useless files after runing make clean or
> make
> >> distclean.
> >>
> >>> On Tue, Jul 12, 2016 at 11:35 AM, Ming Li <mli@pivotal.io> wrote:
> >>>
> >>> LGTM. +1.
> >>>
> >>>> On Tue, Jul 12, 2016 at 11:32 AM, Paul Guo <paulguo@gmail.com>
wrote:
> >>>>
> >>>> I'd mask the output files after running feature tests in .gitignore
> and
> >>>> clean it up after running "make clean" or "make distclean". Anyone has
> >>> any
> >>>> suggestions? Thanks.
> >>>>
> >>>> diff --git a/src/test/feature/.gitignore b/src/test/feature/.gitignore
> >>>> index a2e6bd4..c7332b2 100644
> >>>> --- a/src/test/feature/.gitignore
> >>>> +++ b/src/test/feature/.gitignore
> >>>> @@ -1 +1,2 @@
> >>>> doc/
> >>>> +**/*.out
> >>>>
> >>>> diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
> >>>> index adc6acc..e0985d1 100644
> >>>> --- a/src/test/feature/Makefile
> >>>> +++ b/src/test/feature/Makefile
> >>>> @@ -35,6 +35,7 @@ doc:
> >>>>    doxygen doxygen_template
> >>>>
> >>>> clean distclean: sharelibclean
> >>>> +   find . -type f -name "*.out" |xargs rm -f
> >>>>    $(RM) feature-test
> >>>>    $(RM) feature-test.dSYM
> >>
> >>
> >>
> >> --
> >> Best Regards,
> >> Xiang Sheng
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message