hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Guo <paul...@gmail.com>
Subject Re: About *.out files in test/feature
Date Wed, 20 Jul 2016 01:25:28 GMT
Filed JIRA: HAWQ-942 - Need to .gitignore and make-clean some test files
which are generated after running feature/test
<https://issues.apache.org/jira/browse/HAWQ-942>

If you have more concerns, you can move to JIRA. Closing this thread.
Thanks.

2016-07-12 13:52 GMT+08:00 Paul Guo <paulguo@gmail.com>:

> I think we should remove them in "make distclean/clean" and .gitigore them
> also.
>
> ExternalSource/ans/exttab1.ans
> ExternalSource/sql/exttab1.sql
> UDF/ans/function_creation.ans
> UDF/sql/function_creation.sql
> feature-test
> testlib/ans/template.ans
> testlib/sql/template.sql
>
> By the way, if we remove all .out files in "make distclean/clean", that
> means in the
> future we should leave .out as a protected file suffix. i.e. Files should
> be with .out suffix
> **iff** they are output results after running sql scripts.
>
>
> 2016-07-12 13:40 GMT+08:00 Ming Li <mli@pivotal.io>:
>
>> BTW, is there any pre-processed file with extension .source which will be
>> converted to sql file for testing?
>> Should we also consider these auto-generated sql files?
>> If so, maybe we should move these intermediate files to a temp dir, so
>> that
>> we can distinguish them from normal sql files.
>>
>> On Tue, Jul 12, 2016 at 1:18 PM, Paul Guo <paulguo@gmail.com> wrote:
>>
>> > I would leave .diff file at least unmasked so that people could quickly
>> > find what cases failed.
>> >
>> > 2016-07-12 11:38 GMT+08:00 陶征霖 <ztao1987@apache.org>:
>> >
>> > > Besides .out, there also exists .diff, binary which should be ignored.
>> > >
>> > > 2016-07-12 11:32 GMT+08:00 Paul Guo <paulguo@gmail.com>:
>> > >
>> > > > I'd mask the output files after running feature tests in .gitignore
>> and
>> > > > clean it up after running "make clean" or "make distclean". Anyone
>> has
>> > > any
>> > > > suggestions? Thanks.
>> > > >
>> > > > diff --git a/src/test/feature/.gitignore
>> b/src/test/feature/.gitignore
>> > > > index a2e6bd4..c7332b2 100644
>> > > > --- a/src/test/feature/.gitignore
>> > > > +++ b/src/test/feature/.gitignore
>> > > > @@ -1 +1,2 @@
>> > > >  doc/
>> > > > +**/*.out
>> > > >
>> > > > diff --git a/src/test/feature/Makefile b/src/test/feature/Makefile
>> > > > index adc6acc..e0985d1 100644
>> > > > --- a/src/test/feature/Makefile
>> > > > +++ b/src/test/feature/Makefile
>> > > > @@ -35,6 +35,7 @@ doc:
>> > > >     doxygen doxygen_template
>> > > >
>> > > >  clean distclean: sharelibclean
>> > > > +   find . -type f -name "*.out" |xargs rm -f
>> > > >     $(RM) feature-test
>> > > >     $(RM) feature-test.dSYM
>> > > >
>> > >
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message