hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lili Ma <lil...@apache.org>
Subject Re: Jira comments vs PR comments
Date Wed, 20 Jul 2016 05:31:49 GMT
Agree!  Just keeping the "issue links to" is enough to track the pull
request.  Leaving the comments on JIRA there is more neat.

Thanks
Lili

2016-07-20 10:34 GMT+08:00 Paul Guo <paulguo@gmail.com>:

> +1.  Github has already have fine-grained notification mechanism. I think
> JIRA
> could just pull the initial git pull request info, not each comment in
> github.
>
> I guess this is either a JIRA configuration issue or an asf/infrustructure
> issue.
>
> 2016-07-20 2:57 GMT+08:00 Goden Yao <godenyao@apache.org>:
>
> > 2nd that. JIRA right now can already link to the PR under "issue links
> to"
> > section. (e.g.: https://issues.apache.org/jira/browse/HAWQ-936 )
> > Not sure if that was automatic or manual but I prefer that way instead of
> > auto-pulling every PR comment into the JIRA (even closing PR is a
> comment).
> >
> > JIRA discussion should be focused on the problem to solve and design,
> etc.
> > While PR comments are mainly for coding details, logic errors, naming
> > issues, formats, coding style etc.
> >
> > -Goden
> >
> > On Tue, Jul 19, 2016 at 11:52 AM Shivram Mani <shivram.mani@gmail.com>
> > wrote:
> >
> > > Its great that Jira and github has been linked, but this integration is
> > > also making it hard for us to skim through actual comments posted in
> > Jira.
> > > Jiras usually end up being innundated with every single comment posted
> in
> > > the pull request.
> > > This makes it hard for us to actually read through/search for actual
> > > comments/discussions posted on the Jira amidst the pull requestion
> > > notifications for each comment.
> > >
> > > Can we disable pull request comment based notifications from being
> posted
> > > on the Jira ?
> > > Thoughts ?
> > >
> > > --
> > > shivram mani
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message