hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Roman Shaposhnik <ro...@shaposhnik.org>
Subject Re: Replace git submodule with git clone + file with commit number?
Date Mon, 18 Jul 2016 23:19:20 GMT
I think the branch look good! Thanks for taking care of the feedback.

Thanks,
Roman.

On Wed, Jul 13, 2016 at 8:14 PM, Paul Guo <paulguo@gmail.com> wrote:
> Roman, do you still have any concern about this? Thanks.
>
> 2016-07-08 2:04 GMT+08:00 Roman Shaposhnik <roman@shaposhnik.org>:
>
>> On Thu, Jul 7, 2016 at 3:20 AM, Paul Guo <paulguo@gmail.com> wrote:
>> > For gporca it is ok to pre-build them and pass orca installation path to
>> > hawq, but for
>> > pgcrypto and plr, having a script to run before building hawq seems to
>> not
>> > be a good
>> > idea, technically speaking.
>> >
>> > plr/pgcrypto depends on the configure options and configure checking.
>> > (e.g. with and without openssl option in configure, pgcrypto build
>> results
>> > will be different).
>> >
>> > That means building of these features are not 100% independent on
>> building
>> > of hawq.
>>
>> The above makes sense, but there's way too many ways to interpret the
>> particulars of it. Before we move ahead, how about I take a look at the
>> branch that is being cut (see the other thread) and provide you more
>> technical feedback?
>>
>> Thanks,
>> Roman.
>>

Mime
View raw message