Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <CALpJHBDCNATWAymjy2Xv7ofQ8dpG-QSeZVvaJsur5fut=cbJ_g@mail.gmail.com>
References: <CAA=Rw+G3UJg4=XbjNVMQ0X7BfSDG7=3C1z5q2F0iGcw5hV7SPw@mail.gmail.com>
 <CALpJHBDCNATWAymjy2Xv7ofQ8dpG-QSeZVvaJsur5fut=cbJ_g@mail.gmail.com>
From: Jiali Yao <jyao@pivotal.io>
Date: Fri, 24 Jun 2016 13:31:12 +0800
Message-ID: <CAA=Rw+Fk8zAXg_pEAeYJBgG4s28x2CSrVm==1BYQG+p8LfooJg@mail.gmail.com>
Subject: Re: Integrate ICG to GTest
To: dev@hawq.incubator.apache.org
Content-Type: multipart/alternative; boundary=001a1144736e92e2e20535ff7a0b
archived-at: Fri, 24 Jun 2016 05:31:25 -0000

--001a1144736e92e2e20535ff7a0b
Content-Type: text/plain; charset=UTF-8

+1 for the doc
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md

For test we suggest that all new tests should use google test. Existing
install check good tests should be moved to google test.
What is your thoughts?

Thanks

Jiali


On Fri, Jun 24, 2016 at 1:20 AM, Shivram Mani <shivram.mani@gmail.com>
wrote:

> Thumbs up on transitioning to Google test framework. This is a doc that has
> detailed benefits of Googletest framework
> https://github.com/google/googletest/blob/master/googletest/docs/Primer.md
> .
> How do we plan to transition test to the GTest framework. Are we only going
> to target adding new tests in the framework or do we plan to do a bulk
> transfer of existing test ?
>
> On Fri, Jun 17, 2016 at 1:34 AM, Jiali Yao <jyao@pivotal.io> wrote:
>
> > Hi all,
> >
> > In HAWQ test, google test is used for libyarn and libhdfs test. Install
> > check test framework is used for smoke test and has a lot of limitations.
> > To make it easy to learn and consolidate test, we want to unify the two
> > frameworks. Considering below factors, we want to use google test:
> >
> >    - It supports more functions and then a developer can write more
> complex
> >    tests which are not only limited to SQL test.
> >    - Google test support run test parallelly.
> >    - Google mock is an extension for google test, it can also be used for
> >    unit test.
> >
> > For detail information please refer to
> > https://issues.apache.org/jira/browse/HAWQ-832
> >
> > Looking forward to your comments.
> >
> > Thanks
> >
> > Jiali
> >
>
>
>
> --
> shivram mani
>

--001a1144736e92e2e20535ff7a0b--