Return-Path: <dev-return-4190-archive-asf-public=cust-asf.ponee.io@hawq.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 1E94D200B40
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  2 Jun 2016 06:09:44 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 1D37D160A4D; Thu,  2 Jun 2016 04:09:44 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 629CB160A4C
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  2 Jun 2016 06:09:43 +0200 (CEST)
Received: (qmail 71154 invoked by uid 500); 2 Jun 2016 04:09:42 -0000
Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hawq.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hawq.incubator.apache.org>
List-Post: <mailto:dev@hawq.incubator.apache.org>
List-Id: <dev.hawq.incubator.apache.org>
Reply-To: dev@hawq.incubator.apache.org
Delivered-To: mailing list dev@hawq.incubator.apache.org
Received: (qmail 71142 invoked by uid 99); 2 Jun 2016 04:09:42 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jun 2016 04:09:42 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C4A10C0D08
	for <dev@hawq.apache.org>; Thu,  2 Jun 2016 04:09:41 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -5.446
X-Spam-Level: 
X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-1.426] autolearn=disabled
Received: from mx2-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024)
	with ESMTP id 8NzKqJnMUIOP for <dev@hawq.apache.org>;
	Thu,  2 Jun 2016 04:09:39 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id CF7E55FE3D
	for <dev@hawq.incubator.apache.org>; Thu,  2 Jun 2016 04:09:38 +0000 (UTC)
Received: (qmail 71131 invoked by uid 99); 2 Jun 2016 04:09:38 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jun 2016 04:09:38 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 50F2BE0498; Thu,  2 Jun 2016 04:09:37 +0000 (UTC)
From: jiny2 <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-684-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-684-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request #684: HAWQ-758. Refactor insert checkinstall cas...
Content-Type: text/plain
Message-Id: <20160602040937.50F2BE0498@git1-us-west.apache.org>
Date: Thu,  2 Jun 2016 04:09:37 +0000 (UTC)
archived-at: Thu, 02 Jun 2016 04:09:44 -0000

Github user jiny2 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/684#discussion_r65481777
  
    --- Diff: src/test/feature/query/test-insert.cpp ---
    @@ -0,0 +1,176 @@
    +#include <pwd.h>
    +#include <sys/types.h>
    +#include <unistd.h>
    +#include <vector>
    +#include <stdio.h>
    +#include <stdlib.h>
    +#include <errno.h>
    +#include <iostream>
    +#include <string>
    +
    +#include "lib/command.h"
    +#include "lib/common.h"
    +#include "lib/data-gen.h"
    +#include "lib/hawq-config.h"
    +#include "lib/sql-util.h"
    +
    +#include "gtest/gtest.h"
    +
    --- End diff --
    
    fixing it is ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---