hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lei Chang <lei_ch...@apache.org>
Subject Re: Integrate ICG to GTest
Date Sat, 25 Jun 2016 01:09:33 GMT
first of all, +1 for the proposal consolidating the test frameworks, it
make existing developers daily work easy and also lower the barrier for
contributions from new contributors.

I'd like suggest we move the tests step by step and we can continuously
release.

Cheers
Lei


On Fri, Jun 24, 2016 at 1:31 PM, Jiali Yao <jyao@pivotal.io> wrote:

> +1 for the doc
> https://github.com/google/googletest/blob/master/googletest/docs/Primer.md
>
> For test we suggest that all new tests should use google test. Existing
> install check good tests should be moved to google test.
> What is your thoughts?
>
> Thanks
>
> Jiali
>
>
> On Fri, Jun 24, 2016 at 1:20 AM, Shivram Mani <shivram.mani@gmail.com>
> wrote:
>
> > Thumbs up on transitioning to Google test framework. This is a doc that
> has
> > detailed benefits of Googletest framework
> >
> https://github.com/google/googletest/blob/master/googletest/docs/Primer.md
> > .
> > How do we plan to transition test to the GTest framework. Are we only
> going
> > to target adding new tests in the framework or do we plan to do a bulk
> > transfer of existing test ?
> >
> > On Fri, Jun 17, 2016 at 1:34 AM, Jiali Yao <jyao@pivotal.io> wrote:
> >
> > > Hi all,
> > >
> > > In HAWQ test, google test is used for libyarn and libhdfs test. Install
> > > check test framework is used for smoke test and has a lot of
> limitations.
> > > To make it easy to learn and consolidate test, we want to unify the two
> > > frameworks. Considering below factors, we want to use google test:
> > >
> > >    - It supports more functions and then a developer can write more
> > complex
> > >    tests which are not only limited to SQL test.
> > >    - Google test support run test parallelly.
> > >    - Google mock is an extension for google test, it can also be used
> for
> > >    unit test.
> > >
> > > For detail information please refer to
> > > https://issues.apache.org/jira/browse/HAWQ-832
> > >
> > > Looking forward to your comments.
> > >
> > > Thanks
> > >
> > > Jiali
> > >
> >
> >
> >
> > --
> > shivram mani
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message