hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ictmalili <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request #691: HAWQ-774. Add snappy compression support t...
Date Tue, 07 Jun 2016 02:27:26 GMT
Github user ictmalili commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/691#discussion_r66001516
  
    --- Diff: src/backend/catalog/pg_compression.c ---
    @@ -437,10 +554,11 @@ compresstype_is_valid(char *comptype)
     					 cql("SELECT COUNT(*) FROM pg_compression "
     						 " WHERE compname = :1 ",
     						 NameGetDatum(&compname))));
    -		
    +
    +	/* FIXME: This is a hack. Should register gzip handlers into pg_compression table. */
     	if(!found)
     	{
    -		if((strcmp(comptype, "snappy") == 0) || strcmp(comptype, "gzip") == 0)
    +		if(strcmp(comptype, "gzip") == 0)
    --- End diff --
    
    It's better we remove this hack finally.  Since this commit is for snappy support for
AO, let's move removing gzip hack to another JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message