Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: huor <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-672-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-672-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request: HAWQ-751. Add plr, pgcrypto, gporca i...
Content-Type: text/plain
Message-Id: <20160524020841.12210EAC95@git1-us-west.apache.org>
Date: Tue, 24 May 2016 02:08:41 +0000 (UTC)
archived-at: Tue, 24 May 2016 02:08:47 -0000

Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/672#discussion_r64318728
  
    --- Diff: configure ---
    @@ -1545,7 +1543,8 @@ Optional Packages:
       --with-perl             build Perl modules (PL/Perl)
       --with-python           build Python modules (PL/Python)
       --with-java             build Java modules (PL/Java)
    -  --with-r             build R modules (PL/R)
    +  --with-r                build R modules (PL/R)
    --- End diff --
    
    It would be better to use:
    ```
    --with-plperl
    --with-plpython
    --with-pljava
    --with-plr
    --with-pgcrypto
    ```
    
    Also the comment for "with-pgcrypto" should be "build with pgcrypto"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---