Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: hornn <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-633-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-633-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request: HAWQ-703. Serialize HCatalog Complex ...
Content-Type: text/plain
Message-Id: <20160502225415.917CDDFB73@git1-us-west.apache.org>
Date: Mon,  2 May 2016 22:54:15 +0000 (UTC)
archived-at: Mon, 02 May 2016 22:54:20 -0000

Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/633#discussion_r61818664
  
    --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java ---
    @@ -0,0 +1,112 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * 
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + * 
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.hawq.pxf.plugins.hive.utilities;
    +
    +import org.apache.hawq.pxf.api.utilities.EnumHawqType;
    +import org.apache.hawq.pxf.api.UnsupportedTypeException;
    +
    +/**
    + * 
    + * Hive types, which are supported by plugin, mapped to HAWQ's types
    + * @see EnumHawqType
    + */
    +public enum EnumHiveToHawqType {
    +
    +    TinyintType("tinyint", EnumHawqType.Int2Type),
    +    SmallintType("smallint", EnumHawqType.Int2Type),
    +    IntType("int", EnumHawqType.Int4Type),
    +    BigintType("bigint", EnumHawqType.Int8Type),
    +    BooleanType("boolean", EnumHawqType.BoolType),
    +    FloatType("float", EnumHawqType.Float4Type),
    +    DoubleType("double", EnumHawqType.Float8Type),
    +    StringType("string", EnumHawqType.TextType),
    +    BinaryType("binary", EnumHawqType.ByteaType),
    +    TimestampType("timestamp", EnumHawqType.TimestampType),
    +    DateType("date", EnumHawqType.DateType),
    +    DecimalType("decimal", EnumHawqType.NumericType, "[(,)]"),
    +    VarcharType("varchar", EnumHawqType.VarcharType, "[(,)]"),
    +    CharType("char", EnumHawqType.BpcharType, "[(,)]"),
    +    ArrayType("array", EnumHawqType.TextType, "[<,>]"),
    +    MapType("map", EnumHawqType.TextType, "[<,>]"),
    +    StructType("struct", EnumHawqType.TextType, "[<,>]"),
    +    UnionType("uniontype", EnumHawqType.TextType, "[<,>]");
    +
    +    private String typeName;
    +    private EnumHawqType hawqType;
    +    private String splitExpression;
    +
    +    EnumHiveToHawqType(String typeName, EnumHawqType hawqType) {
    +        this.typeName = typeName;
    +        this.hawqType = hawqType;
    +    }
    +
    +    EnumHiveToHawqType(String typeName, EnumHawqType hawqType, String splitExpression) {
    +        this(typeName, hawqType);
    +        this.splitExpression = splitExpression;
    +    }
    +
    +    /**
    +     * 
    +     * @return name of type
    +     */
    +    public String getTypeName() {
    +        return this.typeName;
    +    }
    +
    +    /**
    +     * 
    +     * @return corresponding HAWQ type
    +     */
    +    public EnumHawqType getHawqType() {
    +        return this.hawqType;
    +    }
    +
    +    /**
    +     * 
    +     * @return split by expression
    +     */
    +    public String getSplitExpression() {
    +        return this.splitExpression;
    +    }
    +
    +    /**
    +     * Returns Hive to HAWQ type mapping entry for given Hive type 
    +     * 
    +     * @param hiveType full Hive type with modifiers, for example - decimal(10, 0), char(5), binary, array<string>, map<string,float> etc
    +     * @return corresponding Hive to HAWQ type mapping entry
    +     * @throws UnsupportedTypeException if there is no corresponding HAWQ type
    +     */
    +    public static EnumHiveToHawqType getHiveToHawqType(String hiveType) {
    +        for (EnumHiveToHawqType t : values()) {
    +            String hiveTypeName = hiveType;
    +            if (t.getSplitExpression() != null) {
    --- End diff --
    
    minor - since t.getSplitExpression() is called twice here, it can be saved in a variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---