hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhangh43 <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-760. Add hawq register to suppor...
Date Fri, 27 May 2016 16:52:49 GMT
Github user zhangh43 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/679#discussion_r64934846
  
    --- Diff: src/test/feature/testhawqregister/test-hawq-register.cpp ---
    @@ -0,0 +1,80 @@
    +#include <string>
    +
    +#include "lib/command.h"
    +#include "lib/common.h"
    +#include "lib/sql-util.h"
    +
    +#include "gtest/gtest.h"
    +
    +using std::string;
    +
    +/* This test suite may consume more than 80 seconds. */
    +class TestHawqRegister : public ::testing::Test {
    + public:
    +  TestHawqRegister() {}
    +  ~TestHawqRegister() {}
    +};
    +
    +TEST_F(TestHawqRegister, TestSingleFile) {
    +	SQLUtility util;
    +	string rootPath(util.getTestRootPath()); 
    +	string relativePath("/testhawqregister/test_hawq.paq");
    +	string filePath = rootPath + relativePath;
    +
    +	EXPECT_EQ(Command::getCommandStatus("hadoop fs -put " + filePath + " /hawq_register_hawq.paq"),
0);
    --- End diff --
    
    EXPECT_EQ(expected_value, your_value), so zero should be the first parameter.
    some other EXPECT_EQ has the same problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message