Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: hornn <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-630-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-630-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request: Fix Orca error message: Orca
 supports...
Content-Type: text/plain
Message-Id: <20160426182434.82CDFDFF70@git1-us-west.apache.org>
Date: Tue, 26 Apr 2016 18:24:34 +0000 (UTC)

Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/630#discussion_r61138397
  
    --- Diff: src/backend/gpopt/translate/CTranslatorUtils.cpp ---
    @@ -1583,9 +1585,9 @@ CTranslatorUtils::PdrgpbsGroupBy
     		return PdrgpbsRollup(pmp, pgrcl, ulCols, phmululGrpColPos, pbsGrpCols);
     	}
     
    -	if (GROUPINGTYPE_GROUPING_SETS != pgrcl->groupType)
    +	if (GROUPINGTYPE_CUBE == pgrcl->groupType)
     	{
    -		GPOS_RAISE(gpdxl::ExmaDXL, gpdxl::ExmiQuery2DXLUnsupportedFeature, GPOS_WSZ_LIT("Rollup and cube"));
    +		GPOS_RAISE(gpdxl::ExmaDXL, gpdxl::ExmiQuery2DXLUnsupportedFeature, GPOS_WSZ_LIT(“Cube”));
    --- End diff --
    
    the quote marks look off. should be `"` and not `“`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---