Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: ztao1987 <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-503-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-503-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request: HAWQ-462. Dispatch dfs_address
 from m...
Content-Type: text/plain
Message-Id: <20160414033230.27AEADFB7C@git1-us-west.apache.org>
Date: Thu, 14 Apr 2016 03:32:30 +0000 (UTC)

Github user ztao1987 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/503#discussion_r59659407
  
    --- Diff: src/backend/cdb/cdbquerycontextdispatching.c ---
    @@ -770,6 +770,30 @@ RebuildTupleForRelation(QueryContextInfo *cxt)
     }
     
     /*
    + * Deserialize the Namespace data
    + */
    +static void
    +RebuildNamespace(QueryContextInfo *cxt)
    +{
    +
    +	int len;
    +	char buffer[4], *binary;
    +	ReadData(cxt, buffer, sizeof(buffer), TRUE);
    +
    +	len = (int) ntohl(*(uint32 *) buffer);
    +	binary = palloc(len);
    +	if(ReadData(cxt, binary, len, TRUE))
    +	{
    +		StringInfoData buffer;
    +		initStringInfoOfString(&buffer, binary, len);
    +		dfs_address = strdup(buffer.data);
    --- End diff --
    
    Why not just strdup(binary) to dfs_address? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---