Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: sansanichfb <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-595-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-595-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request: HAWQ-628. Return -1 instead of
 error.
Content-Type: text/plain
Message-Id: <20160412220814.578B7DFC4F@git1-us-west.apache.org>
Date: Tue, 12 Apr 2016 22:08:14 +0000 (UTC)

Github user sansanichfb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/595#discussion_r59462863
  
    --- Diff: src/backend/utils/adt/dbsize.c ---
    @@ -180,9 +180,7 @@ calculate_database_size(Oid dbOid)
     	Assert(Gp_role != GP_ROLE_EXECUTE);
     
     	if (dbOid == HcatalogDbOid)
    -		ereport(ERROR,
    -			(ERRCODE_UNDEFINED_DATABASE,
    -			errmsg("database hcatalog (OID 6120) is reserved")));
    +		return -1;
    --- End diff --
    
    Added comment to justify.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---