Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: cbaenziger <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-250-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-250-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request: HAWQ-307. Ubuntu Support
Content-Type: text/plain
Message-Id: <20160412065646.CC55EDFA6F@git1-us-west.apache.org>
Date: Tue, 12 Apr 2016 06:56:46 +0000 (UTC)

Github user cbaenziger commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/250#discussion_r59328386
  
    --- Diff: tools/bin/gppylib/commands/unix.py ---
    @@ -925,7 +925,7 @@ def getDescendentProcesses(pid):
         children = list()
         grandchildren = list()
     
    -    for p in psi.process.ProcessTable().values():
    +    for p in psutil.process.ProcessTable().values():
    --- End diff --
    
    Just to close the loop on this. The psi module does not ship for Ubuntu any more (at least out of the box with `pip` or via standard apt repos) from what I can tell with Ubuntu 14.04; it has not been touched since 2010 either. The psutil module is largely API compatible and maintained: shipping for both CentOS and Ubuntu via pip or packages.
    
    For reference, it looks like GPDB has decided to do the same for these  now too: https://github.com/greenplum-db/gpdb/pull/486
    
    Further, I did not find a test suite, so I tried to migrate this as much as possible; looking at the changes the Greenplum community did, clearly I missed a lot of necessary changes here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---