hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From radarwave <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-668. hawq check should be able t...
Date Tue, 19 Apr 2016 07:35:31 GMT
Github user radarwave commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/622#discussion_r60184397
  
    --- Diff: tools/bin/gpcheck ---
    @@ -567,7 +683,7 @@ def testHAWQ(host):
                 return
     
             # check HAWQ master's memory size
    -        expected_vmemory_size = 1024
    +        expected_vmemory_size = 8192
    --- End diff --
    
    If user set the value too big, like set it as '81920' by mistake, 'hawq check' won't give
a warning since it's bigger than the expect values.
    
    So I think we can keep current way. User will decide wether to fix a hawq check warning
base on the document and their environment. 
    
    If any new requirement, we can change it in another jira. Thanks.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message