hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From denalex <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-668. hawq check should be able t...
Date Tue, 19 Apr 2016 05:21:36 GMT
Github user denalex commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/622#discussion_r60174348
  
    --- Diff: tools/bin/gpcheck ---
    @@ -567,7 +683,7 @@ def testHAWQ(host):
                 return
     
             # check HAWQ master's memory size
    -        expected_vmemory_size = 1024
    +        expected_vmemory_size = 8192
    --- End diff --
    
    do we want to check exact value, or minimal value ? in other words, should it be guc_vmemsize_master
< expected_vmemory_size rather than guc_vmemsize_master != expected_vmemory_size in the
statement below and other similar comparisons ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message