hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kavinderd <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-462. Dispatch dfs_address from m...
Date Thu, 14 Apr 2016 03:37:20 GMT
Github user kavinderd commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/503#discussion_r59659665
  
    --- Diff: src/backend/cdb/cdbquerycontextdispatching.c ---
    @@ -770,6 +770,30 @@ RebuildTupleForRelation(QueryContextInfo *cxt)
     }
     
     /*
    + * Deserialize the Namespace data
    + */
    +static void
    +RebuildNamespace(QueryContextInfo *cxt)
    +{
    +
    +	int len;
    +	char buffer[4], *binary;
    +	ReadData(cxt, buffer, sizeof(buffer), TRUE);
    +
    +	len = (int) ntohl(*(uint32 *) buffer);
    +	binary = palloc(len);
    +	if(ReadData(cxt, binary, len, TRUE))
    +	{
    +		StringInfoData buffer;
    +		initStringInfoOfString(&buffer, binary, len);
    +		dfs_address = strdup(buffer.data);
    --- End diff --
    
    Good point, no need for `buffer`. I'll update this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message