hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wangzw <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-635. QE process does not exit in...
Date Thu, 07 Apr 2016 09:08:45 GMT
Github user wangzw commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/564#issuecomment-206774175
  
    If the issue is caused by the exception thrown by RpcClientImpl::getChannel(). The only
chance is that the system run out of memory or fail to create thread.  In either case, you
will see error message "RpcClient failed to create a channel to" in HAWQ log. 
    
    Please refer the code in RpcClientImpl::getChannel()
    
    
        try {
           ...
    
            rc->addRef();
    
            if (!cleaning) {
                cleaning = true;
    
                if (cleaner.joinable()) {
                    cleaner.join();
                }
    
                CREATE_THREAD(cleaner, bind(&RpcClientImpl::clean, this));
            }
        } catch ...
    
    
    
    Isn't it much easier to fix this issue by moving ```rc->addRef();``` to the end of
the ```try``` block?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message