hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-615. Handle incomptible tables w...
Date Tue, 05 Apr 2016 01:00:29 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/551#discussion_r58473430
  
    --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveMetadataFetcher.java
---
    @@ -62,11 +74,24 @@ public HiveMetadataFetcher(InputData md) {
     
             List<Metadata> metadataList = new ArrayList<Metadata>();
     
    +        if(tblsDesc.size() > 1) {
    --- End diff --
    
    What if there are 2 tables but both are not supported? in that case the function will
return 0 tables. Is that an acceptable scenario? if so, perhaps add a test to cover it?
    
    Did you consider changing the condition to have at least one 'good' table - check in the
end of the loop if there metadataList is not empty. If it is, throw an exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message