Return-Path: X-Original-To: apmail-hawq-dev-archive@minotaur.apache.org Delivered-To: apmail-hawq-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 87E1519EC9 for ; Thu, 31 Mar 2016 09:24:40 +0000 (UTC) Received: (qmail 67250 invoked by uid 500); 31 Mar 2016 09:24:33 -0000 Delivered-To: apmail-hawq-dev-archive@hawq.apache.org Received: (qmail 67197 invoked by uid 500); 31 Mar 2016 09:24:33 -0000 Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list dev@hawq.incubator.apache.org Received: (qmail 66785 invoked by uid 99); 31 Mar 2016 09:24:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Mar 2016 09:24:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A8A4D180497 for ; Thu, 31 Mar 2016 09:24:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 1gIQ4B3Zje-x for ; Thu, 31 Mar 2016 09:24:30 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id E0FFC5F246 for ; Thu, 31 Mar 2016 09:24:29 +0000 (UTC) Received: (qmail 65694 invoked by uid 99); 31 Mar 2016 09:24:29 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Mar 2016 09:24:29 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0A503DFDCF; Thu, 31 Mar 2016 09:24:29 +0000 (UTC) From: liming01 To: dev@hawq.incubator.apache.org Reply-To: dev@hawq.incubator.apache.org Message-ID: Subject: [GitHub] incubator-hawq pull request: HAWQ-613. Cannot cancel query when PL... Content-Type: text/plain Date: Thu, 31 Mar 2016 09:24:29 +0000 (UTC) GitHub user liming01 opened a pull request: https://github.com/apache/incubator-hawq/pull/541 HAWQ-613. Cannot cancel query when PL UDF has infinity loops Notes: (1) Here just change some UDF calling may introduce hung problem, I don't go through all code lines PL UDF maybe called. (2) in client_read_ended(), i just set QueryCancelPending to saveQueryCancelPending, instead of set it to false, it means it only process the cancel request during client read period. (3) InterruptWhenCallingPLUDF need to be reset during error report and process exists. Please review, thanks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liming01/incubator-hawq mli/cancel_udf_hung Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/541.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #541 ---- commit ab3c3e587210611f9d8fdb1b25c358ea26fe4d65 Author: Ming LI Date: 2016-03-31T09:14:34Z HAWQ-613. Cannot cancel query when PL UDF has infinity loops ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---