Return-Path: X-Original-To: apmail-hawq-dev-archive@minotaur.apache.org Delivered-To: apmail-hawq-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 36DA81916A for ; Thu, 24 Mar 2016 14:17:59 +0000 (UTC) Received: (qmail 39900 invoked by uid 500); 24 Mar 2016 14:17:59 -0000 Delivered-To: apmail-hawq-dev-archive@hawq.apache.org Received: (qmail 39844 invoked by uid 500); 24 Mar 2016 14:17:59 -0000 Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list dev@hawq.incubator.apache.org Received: (qmail 39833 invoked by uid 99); 24 Mar 2016 14:17:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2016 14:17:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 436D3C2D1F for ; Thu, 24 Mar 2016 14:17:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id bOcC3bKJtdQQ for ; Thu, 24 Mar 2016 14:17:57 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id EF0F25FAD4 for ; Thu, 24 Mar 2016 14:17:56 +0000 (UTC) Received: (qmail 39818 invoked by uid 99); 24 Mar 2016 14:17:56 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2016 14:17:56 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0DD71DFC6E; Thu, 24 Mar 2016 14:17:56 +0000 (UTC) From: kavinderd To: dev@hawq.incubator.apache.org Reply-To: dev@hawq.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-hawq pull request: Writable security fix Content-Type: text/plain Message-Id: <20160324141756.0DD71DFC6E@git1-us-west.apache.org> Date: Thu, 24 Mar 2016 14:17:56 +0000 (UTC) Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/497#discussion_r57322366 --- Diff: src/backend/access/external/fileam.c --- @@ -681,6 +687,8 @@ external_insert(ExternalInsertDesc extInsertDesc, HeapTuple instup) fcinfo.arg[0] = HeapTupleGetDatum(instup); fcinfo.argnull[0] = false; + fcinfo.arg[1] = "test"; --- End diff -- Remnants of when I was prototyping the solution. Will remove. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---