Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: shivzone <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-477-incubator-hawq@git.apache.org>
In-Reply-To: <git-pr-477-incubator-hawq@git.apache.org>
Subject: [GitHub] incubator-hawq pull request: HAWQ 459 Enhanced metadata api
 to sup...
Content-Type: text/plain
Message-Id: <20160322000759.8FC4CDFA42@git1-us-west.apache.org>
Date: Tue, 22 Mar 2016 00:07:59 +0000 (UTC)

Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/477#discussion_r56919089
  
    --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/Metadata.java ---
    @@ -26,51 +26,52 @@
     import org.apache.commons.lang.StringUtils;
     
     /**
    - * Metadata holds a table's metadata information.
    - * {@link MetadataFetcher#getTableMetadata} returns the table's metadata.
    + * Metadata holds an item's metadata information.
    + * {@link MetadataFetcher#getMetadata} returns the item's metadata.
      */
     public class Metadata {
     
         /**
    -     * Class representing table name - db (schema) name and table name.
    +     * Class representing item name - db/schema/path name and table/file name.
          */
    -    public static class Table {
    -        private String dbName;
    -        private String tableName;
    +    public static class Item {
    +        private String path;
    +        private String name;
     
    -        public Table(String dbName, String tableName) {
    +        public Item(String path, String itemName) {
     
    -            if (StringUtils.isBlank(dbName) || StringUtils.isBlank(tableName)) {
    -                throw new IllegalArgumentException("Table name cannot be empty");
    +            if (StringUtils.isBlank(path) || StringUtils.isBlank(itemName)) {
    +                throw new IllegalArgumentException("Item name cannot be empty");
    --- End diff --
    
    this checks for both


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---