hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-601. Clear external table code.
Date Tue, 29 Mar 2016 02:42:43 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/525#discussion_r57665601
  
    --- Diff: src/backend/cdb/cdbdatalocality.c ---
    @@ -768,12 +769,23 @@ static void check_keep_hash_and_external_table(
     			 * whose default value is set to default_segment_num
     			 */
     			ExtTableEntry* extEnrty = GetExtTableEntry(rel->rd_id);
    -			if(extEnrty->command){
    -				// command external table case
    -				if (context->externTableOnClauseSegNum == 0) {
    -					context->externTableOnClauseSegNum = targetPolicy->bucketnum;
    +
    +			bool isPxf = false;
    +			if(!extEnrty->command && extEnrty->locations){
    --- End diff --
    
    missing spaces after `if` and before `{`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message