hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kavinderd <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: Writable security fix
Date Thu, 24 Mar 2016 14:15:32 GMT
Github user kavinderd commented on a diff in the pull request:

    --- Diff: src/bin/gpfusion/gpbridgeapi.c ---
    @@ -273,6 +277,26 @@ void gpbridge_export_start(PG_FUNCTION_ARGS)
    +void parse_namespace(char *uri, char** extracted_namespace){
    +	int i = 0;
    +	int len = strlen(uri);
    +	while(uri[i] != '*' && i < len){
    --- End diff --
    Good point on the delimiter, I'll replace it.
    I chose not to parse the URI in `parseGPHDUri` because even with this fix we will support
two different flows for the readable and writable case. So this is a temporary solution whose
effects I wanted to contain only to writable cases.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message