hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liming01 <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ 569. Fixing an assertion failure...
Date Thu, 24 Mar 2016 08:46:49 GMT
Github user liming01 commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/478#issuecomment-200738453
  
    Hi @armenatzoglou,
    
    I had merged it into branch master for the release date coming. 
    
    But I have a question: it seems that your fix doesn't fix the problem: 
    (1) you just move the line  'queryEntry = NULL;'  one line( if clause ) ahead.
    (2) moreover, the interrupt may occurs before the line 'queryEntry = NULL;' after called
SyncHTRelease(). 
    
    The solution I suggest: 
    (1)If all memory and resource can be released even if WorkfileQueryspace_ReleaseEntry()
not called. e.g. all memory palloced will be released for specific memory context released(
transaction finished/statement execution finished....), then we can move the line 'queryEntry
= NULL;'  to the line before calling SyncHTRelease().
    (2) If cannot be auto-cleaned, then we should "HOLD_INTERRUPTS();" until we set  'queryEntry
= NULL;' 
    
    Thanks.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message