hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: Writable security fix
Date Thu, 24 Mar 2016 02:30:28 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/497#discussion_r57267606
  
    --- Diff: src/bin/gpfusion/gpbridgeapi.c ---
    @@ -273,6 +277,26 @@ void gpbridge_export_start(PG_FUNCTION_ARGS)
     
     }
     
    +void parse_namespace(char *uri, char** extracted_namespace){
    +	int i = 0;
    +	int len = strlen(uri);
    +
    +	while(uri[i] != '*' && i < len){
    --- End diff --
    
    Actually, shouldn't we parse the URI as part of the parse function we already have? that
way we can know that we parsed everything else before we expect to read the delimiter and
the dfs_address - similar to the way it's implemented right now, when we parse dfs_address
that was appended by hd_work_mgr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message