hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: Writable security fix
Date Thu, 24 Mar 2016 02:21:09 GMT
Github user hornn commented on a diff in the pull request:

    --- Diff: src/bin/gpfusion/gpbridgeapi.c ---
    @@ -273,6 +277,26 @@ void gpbridge_export_start(PG_FUNCTION_ARGS)
    +void parse_namespace(char *uri, char** extracted_namespace){
    +	int i = 0;
    +	int len = strlen(uri);
    +	while(uri[i] != '*' && i < len){
    --- End diff --
    `*` can be part of the PXF location (URL), because we support regex matching for file
names (e.g. `file*.txt`).
    If this is going to be a permanent part of the URL (not just for secured env), perhaps
we can scan from the end? 
    Another option is to replace the delimiter.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message