hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sansanichfb <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ 459 Enhanced metadata api to sup...
Date Wed, 23 Mar 2016 19:44:09 GMT
Github user sansanichfb commented on a diff in the pull request:

    --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
    @@ -203,19 +205,37 @@ private static boolean verifyModifers(String[] modifiers) {
          * It can be either <code>table_name</code> or <code>db_name.table_name</code>.
          * @param qualifiedName Hive table name
    -     * @return {@link org.apache.hawq.pxf.api.Metadata.Table} object holding the full
table name
    +     * @return {@link Metadata.Item} object holding the full table name
    -    public static Metadata.Table parseTableQualifiedName(String qualifiedName) {
    +    public static Metadata.Item extractTableFromName(String qualifiedName) {
    +        List<Metadata.Item> items = extractTablesFromPattern(null, qualifiedName);
    +        if(items.isEmpty()) {
    +            throw new IllegalArgumentException("No tables found");
    --- End diff --
    Yes, I saw that one, it's handle_special_error method in libchurl.c. We definitely should
enhance error handling, but as for now the most common case is - when we didn't find any items
matching specified pattern, so I think in this case we should just return empty response and
200 http code.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message