hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ 459 Enhanced metadata api to sup...
Date Wed, 23 Mar 2016 18:42:52 GMT
Github user hornn commented on a diff in the pull request:

    --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
    @@ -203,19 +205,37 @@ private static boolean verifyModifers(String[] modifiers) {
          * It can be either <code>table_name</code> or <code>db_name.table_name</code>.
          * @param qualifiedName Hive table name
    -     * @return {@link org.apache.hawq.pxf.api.Metadata.Table} object holding the full
table name
    +     * @return {@link Metadata.Item} object holding the full table name
    -    public static Metadata.Table parseTableQualifiedName(String qualifiedName) {
    +    public static Metadata.Item extractTableFromName(String qualifiedName) {
    +        List<Metadata.Item> items = extractTablesFromPattern(null, qualifiedName);
    +        if(items.isEmpty()) {
    +            throw new IllegalArgumentException("No tables found");
    --- End diff --
    We have code in HAWQ (in libchurl) that already handles exceptions from PXF. It could
be improved of course, but we cannot rely solely on json because some exceptions are thrown
directly from tomcat, or are a result of connectivity issue.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message