hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiny2 <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-573. Fix Resource leak when canc...
Date Wed, 23 Mar 2016 01:57:31 GMT
Github user jiny2 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/486#discussion_r57099663
  
    --- Diff: src/backend/resourcemanager/communication/rmcomm_QD2RM.c ---
    @@ -461,7 +462,22 @@ int cleanupQD2RMComm(void)
         {
             if ( QD2RM_ResourceSets[i] != NULL )
             {
    -            if ( QD2RM_ResourceSets[i]->QD_ResourceList != NULL )
    +            if (ResourceIndex == i)
    --- End diff --
    
    What does ResourceIndex stand for? why it needs special processing logic comparing with
the other resource contexts? Is it ok to use the same logic in the else block below?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message