hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-465. Implement stored procedure ...
Date Tue, 22 Mar 2016 18:19:01 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/479#discussion_r57040862
  
    --- Diff: src/backend/catalog/external/externalmd.c ---
    @@ -45,22 +46,25 @@
     #include "utils/numeric.h"
     #include "utils/guc.h"
     
    -static HCatalogTable *ParseHCatalogTable(struct json_object *hcatalogMD);
    -static void LoadHCatalogEntry(HCatalogTable *hcatalogTable);
    -static Oid LoadHCatalogNamespace(const char *namespaceName);
    -static void LoadHCatalogTable(Oid namespaceOid, HCatalogTable *hcatalogTable);
    -static void LoadHCatalogType(Oid relid, Oid reltypeoid, NameData relname, Oid relnamespaceoid);
    -static void LoadHCatalogDistributionPolicy(Oid relid, HCatalogTable *hcatalogTable);
    -static void LoadHCatalogExtTable(Oid relid, HCatalogTable *hcatalogTable);
    -static void LoadHCatalogColumns(Oid relid, List *columns);
    +
    +List *ParsePxfEntries(StringInfo json, char *profile, Oid dboid);
    --- End diff --
    
    are all of these functions static? if so, please add `static`, to make the code more clear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message