hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ 459 Enhanced metadata api to sup...
Date Tue, 22 Mar 2016 03:36:05 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/477#discussion_r56933378
  
    --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/MetadataResponseFormatter.java
---
    @@ -55,50 +54,65 @@ public static String formatResponseString(Metadata metadata) throws
IOException
          * To be used as the result string for HAWQ.
          * An example result is as follows:
          *
    -     * {"PXFMetadata":[{"table":{"dbName":"default","tableName":"t1"},"fields":[{"name":"a","type":"int"},{"name":"b","type":"float"}]}]}
    +     * {"PXFMetadata":[{"item":{"path":"default","name":"t1"},"fields":[{"name":"a","type":"int"},{"name":"b","type":"float"}]}]}
          */
    -    private static String metadataToJSON(Metadata metadata) throws IOException {
    +    private static String metadataToJSON(List<Metadata> metadataList) throws IOException
{
     
    -        if (metadata == null) {
    -            throw new IllegalArgumentException("metadata object is null - cannot serialize");
    +        if (metadataList == null || metadataList.isEmpty()) {
    +            throw new IllegalArgumentException("no metadata objects found - cannot serialize");
             }
     
    -        if ((metadata.getFields() == null) || metadata.getFields().isEmpty()) {
    -            throw new IllegalArgumentException("metadata contains no fields - cannot
serialize");
    +        StringBuilder result = null;
    +
    +        for(Metadata metadata: metadataList) {
    +            if(metadata == null) {
    +                throw new IllegalArgumentException("metadata object is null - cannot
serialize");
    +            }
    +            if ((metadata.getFields() == null) || metadata.getFields().isEmpty()) {
    +                throw new IllegalArgumentException("metadata contains no fields - cannot
serialize");
    --- End diff --
    
    do you want to specify what is the faulty item or do we not care?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message