hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ 459 Enhanced metadata api to sup...
Date Tue, 22 Mar 2016 03:33:06 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/477#discussion_r56933223
  
    --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/MetadataFetcherFactory.java
---
    @@ -28,7 +30,12 @@
      * abstract class which is returned by the MetadataFetcherFactory. 
      */
     public class MetadataFetcherFactory {
    -    static public MetadataFetcher create(String fetcherName) throws Exception {
    -        return (MetadataFetcher) Class.forName(fetcherName).newInstance();
    +    /* TODO: This is a tempororary workaround.
    +     * The metadata class will be moved to the pxf-profile.xml in the future
    +     */
    --- End diff --
    
    btw, why is it temporary? currently, both profile and specific plugin names are supported
- so it will probably be possible to define a profile that includes the metadata fetcher,
or specify the metadata fetcher itself. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message