hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From foyzur <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-544. Fixed assertion failure in ...
Date Fri, 18 Mar 2016 21:39:06 GMT
Github user foyzur commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/454#issuecomment-198554875
  
    Hi @ictmalili the HandleMemoryAccountingGenerationOverflow() is not supposed to allocate
more memory. Part of the job of the assert ```Assert(RolloverMemoryAccount->peak >=
MemoryAccountingPeakBalance);``` is to make sure that all the allocated memory are now owned
by RolloverMemoryAccount. If we allow further allocation during the migration process, it
will be very difficult (if not impossible) to ensure that. Therefore, the assert should itself
prevent further allocation, if any, made by accidental future change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message