hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiny2 <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: Hawq-473. Implement adding a entry in...
Date Fri, 11 Mar 2016 08:40:43 GMT
Github user jiny2 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/430#discussion_r55802728
  
    --- Diff: src/backend/resourcemanager/resourcepool.c ---
    @@ -844,22 +936,38 @@ int addHAWQSegWithSegStat(SegStat segstat, bool *capstatchanged)
     					  	  	       TYPCONVERT(void *, &hostaddrkey)) == NULL )
     			{
     				setHASHTABLENode( &(PRESPOOL->SegmentHostAddrIndexed),
    -							  	  TYPCONVERT(void *, &hostaddrkey),
    +								  TYPCONVERT(void *, &hostaddrkey),
     								  TYPCONVERT(void *, segid),
     								  false /* There should be no old value. */);
     
     				elog(LOG, "Resource manager tracked ip address '%.*s' for host '%s'",
     						  hostaddrkey.Len, hostaddrkey.Array,
    -					      hostname);
    +						  hostname);
     			}
     		}
     
     		/*
    -		 * This is a new host registration. Normally the status is available,
    -		 * But if the number of failed temporary directory exceeds guc,
    +		 * If in Yarn mode, the new registered segment is marked
    +		 * as DOWN, since master hasn't get a cluster report for it from YARN.
    +		 */
    +		if (DRMGlobalInstance->ImpType != NONE_HAWQ2)
    +		{
    +			segresource->Stat->StatusDesc |= SEG_STATUS_NO_YARN_NODE_REPORT;
    --- End diff --
    
    suggest to change to SET_STATUS_NO_GRM_NODE_REPORT , in the future, maybe more global
resource managers are supported.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message