hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-462. Adding dfs_address from pgf...
Date Wed, 09 Mar 2016 01:29:00 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/412#discussion_r55459533
  
    --- Diff: src/backend/access/external/pxfuriparser.c ---
    @@ -634,9 +638,20 @@ GPHDUri_parse_segwork(GPHDUri *uri, const char *uri_str)
     	segwork = strstr(uri_str, segwork_substring);
     	if (segwork == NULL)
     		return;
    -
     	segwork += strlen(segwork_substring);
     
    +	if (enable_secure_filesystem)
    +	{
    +		/* parse dfs address */
    +		size_end = strchr(segwork, segwork_dfs_separator);
    +		if(size_end != NULL)
    --- End diff --
    
    if it's a secured environment, if there is no dfs address data maybe we should error out.
What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message