hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivzone <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-462. Adding dfs_address from pgf...
Date Fri, 04 Mar 2016 21:35:35 GMT
Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/412#discussion_r55092296
  
    --- Diff: src/backend/access/external/hd_work_mgr.c ---
    @@ -783,6 +786,10 @@ make_allocation_output_string(List *segment_fragments)
     		appendStringInfoChar(&fragment_str, SEGWORK_IN_PAIR_DELIM);
     		if (frag->fragment_md)
     			appendStringInfo(&fragment_str, "%s", frag->fragment_md);
    +		/* Adding dfs_address from pg_filespace entry required for HAWQ-462 */
    +		appendStringInfoChar(&fragment_str, SEGWORK_IN_PAIR_DELIM);
    +		if (dfs_address)
    --- End diff --
    
    Yes, this is the first cut solution, the optimal solution is to pass it as part of the
segment level data instead of fragment. Wasn't quite able to figure out how to add additional
metadata with the segment data. Wanted to first certify against secure cluster before investigating
addition into segment data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message