hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hornn <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request: HAWQ-462. Adding dfs_address from pgf...
Date Fri, 04 Mar 2016 20:17:18 GMT
Github user hornn commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/412#discussion_r55083101
  
    --- Diff: src/backend/access/external/pxfuriparser.c ---
    @@ -719,7 +727,7 @@ GPHDUri_parse_fragment(char* fragment, List* fragments)
     		has_user_data = true;
     		*value_end = '\0';
     	}
    -	fragment_data->fragment_md = pstrdup(value_start);
    +	fragment_data->dfs_address = pstrdup(value_start);
    --- End diff --
    
    please make sure to pfree it in GPHDUri_free_fragments.
    I also noticed that we don't free fragment_md and user_data.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message